[Alerting v2] [Rule authoring] Add compressed prop to flyout rule form fields#260936
Open
yiannisnikolopoulos wants to merge 1 commit intoelastic:mainfrom
Open
Conversation
yiannisnikolopoulos
added
release_note:skip
github-actions
bot
added
the
author:actionable-obs
Contributor
ApprovabilityVerdict: Needs human review Mechanical UI change adding You can customize Macroscope's approvability policy. Learn more. |
baileycash-elastic
approved these changes
Apr 2, 2026
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes elastic/rna-program#244
Summary
Applies EUI
compresseddensity to all form input components when the rule form is rendered in flyout layout (layout === 'flyout'). The full-page layout is unaffected.The change follows the pattern established in #260750: read
layoutfromuseRuleFormMeta()and conditionally apply flyout-specific props.What changed
Shared utility components — added a
compressedprop to the interface so callers can pass it down without these components reaching into context:NumberInput— forwarded toEuiFieldNumbervia...restDurationInput— passed explicitly toNumberInputandEuiSelectLookbackWindow,RuleSchedule— forwarded via{...props}spread toDurationInputField components — each reads
const { layout } = useRuleFormMeta()and passescompressed={layout === 'flyout'}to its EUI input:TagsField→EuiComboBoxDescriptionField→EuiTextAreaRecoveryTypeField→EuiSelectGroupFieldSelect→EuiComboBoxTimeFieldSelect→EuiSelectScheduleField/LookbackWindowField→ threaded down toDurationInputAlertDelayField/RecoveryDelayField→EuiButtonGroup buttonSize('compressed'in flyout,'s'in page)StateTransitionCountField→NumberInputStateTransitionTimeframeField→DurationInputExcluded (no
compressedprop in EUI):NameField(EuiInlineEditTitle),KindField(EuiCheckableCard),RunbookField(markdown modal).Testing
tags_field.test.tsx(was missing)